Skip to content

Implement PcntlForkJobRunner #6288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Implement PcntlForkJobRunner #6288

wants to merge 1 commit into from

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Aug 3, 2025 •
edited
Loading

running
php phpunit tests/end-to-end/phar/tests/standard/GreeterTest.php -c tests/end-to-end/phar/phpunit.xml
with a fork Time: 00:00.005, Memory: 16.00 MB
with a subprocess Time: 00:00.031, Memory: 16.00 MB

Todo

  • implement PcntlForkJobRunner
  • make CI run with pcntl
  • fix tests
  • add attribute parameter to RunTestsInSeparateProcesses, RunInSeparateProcess to opt-in fork-mode

@staabm staabm mentioned this pull request Aug 3, 2025
Closed
@staabm
Copy link
Contributor Author

staabm commented Aug 3, 2025 •
edited
Loading

currently one test is failling:

1) /Users/staabm/workspace/phpunit/tests/end-to-end/regression/5592-process-isolation.phpt
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
 
 --
 
-There was 1 risky test:
+There were 2 risky tests:
 
 1) PHPUnit\TestFixture\Issue5592Test::testRemovedErrorHandler
 Test code or tested code removed error handlers other than its own
@@ @@
 
 /Users/staabm/workspace/phpunit/tests/end-to-end/regression/5592/Issue5592Test.php:33
 
+2) PHPUnit\TestFixture\Issue5592Test::testRemovedExceptionHandler
+Test code or tested code removed exception handlers other than its own
+
+/Users/staabm/workspace/phpunit/tests/end-to-end/regression/5592/Issue5592Test.php:52
+
 FAILURES!
-Tests: 6, Assertions: 6, Failures: 4, Risky: 1.
+Tests: 6, Assertions: 6, Failures: 4, Risky: 2.

/Users/staabm/workspace/phpunit/tests/end-to-end/regression/5592-process-isolation.phpt:45
/Users/staabm/workspace/phpunit/src/Framework/TestSuite.php:374
/Users/staabm/workspace/phpunit/src/Framework/TestSuite.php:374
/Users/staabm/workspace/phpunit/src/TextUI/TestRunner.php:64
/Users/staabm/workspace/phpunit/src/TextUI/Application.php:228

FAILURES!
Tests: 4591, Assertions: 12200, Failures: 1, Skipped: 23, Incomplete: 1.

... I wonder why 0e4f6d8 started to ignore "Test code or tested code did not remove its own error handlers" when test run in isolation, but did not the same for "Test code or tested code removed error handlers other than its own" ?

edit: answered in 0e4f6d8#r163466240

@staabm staabm force-pushed the fork5 branch 3 times, most recently from b4854bd to c4897e6 Compare August 4, 2025 14:36
@staabm staabm mentioned this pull request Aug 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@staabm